feat: mobile interactions with input actions #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuruk-mm
changed the title
leanmendoza
approved these changes
Jan 26, 2024
| @@ -13,13 +13,17 @@ func set_pointer_data(interacts_array: Array): | |||
| child.queue_free() | |||
| var i = 0 | |||
| for interact in interacts_array: | |||
| if i >= angles.size(): | |||
There was a problem hiding this comment.
Does this discard the remaining interactions?
There was a problem hiding this comment.
Yes. It avoids a crash. In the Foundation Client is crashing. And Godot was crashing too due to not having enough angles.
There is no limit to how many tooltip interactions you can have from SDK7. So the Explorer having a hard limit of 5 it's more than ok for me at least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #149